feat: raise 405/406 on predicate mismatches#3811
Open
miketheman wants to merge 1 commit intoPylons:mainfrom
Open
feat: raise 405/406 on predicate mismatches#3811miketheman wants to merge 1 commit intoPylons:mainfrom
miketheman wants to merge 1 commit intoPylons:mainfrom
Conversation
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
feat/predictate-mismatches
branch
from
977d990 to
c76449b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to solve #1526
I guided Claude Code for this implementation while reviewing each step, and correcting where needed.
The delayed import statements inside
PredicateMismatchprevent circular imports, not sure if there's a better approach here.An existing test changed is
test_it_raises_predicate_mismatch(renamed totest_it_raises_405_on_request_method_mismatch) since that's the only behavioral change I could identify.Looking forward to your thoughts!