add require_csrf argument to add_jsonrpc_endpoint#47
Open
ztane wants to merge 3 commits into
Open
Conversation
Author
|
I didn't touch XML-RPC stuff, because I just need the JSON-RPC right now and ASAP. |
mmerickel
requested changes
Aug 30, 2017
mmerickel
left a comment
mmerickel
left a comment
Member
There was a problem hiding this comment.
Thanks this looks fine but prior to release this needs the following updates:
- Fix exception views to always have
require_csrf=False. - Drop support for Pyramid < 1.7 in
tox.iniand in documentation. - Add
require_csrfto xmlrpc.
| config.add_view(exception_view, route_name=name, context=Exception, | ||
| permission=NO_PERMISSION_REQUIRED) | ||
| permission=NO_PERMISSION_REQUIRED, | ||
| require_csrf=require_csrf) |
Member
There was a problem hiding this comment.
This is an exception view, it should always have require_csrf=False.
Also the JsonRpcError exception view in the includeme should also have require_csrf=False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.