When Transfer-Encoding is set, and Content-Length, close connection#475
Merged
Conversation
RFC9112 adds an additional requirement when parsing a request that has both content-length and transfer-encoding set, which is that the connection should be closed after a single use to avoid potential pitfalls with request smuggling/parser desync between multiple implementations. So now we check to see if the content-length was also set, and if so, we close the connection after the request is completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC9112 adds an additional requirement when parsing a request that has both content-length and transfer-encoding set, which is that the connection should be closed after a single use to avoid potential pitfalls with request smuggling/parser desync between multiple implementations.
So now we check to see if the content-length was also set, and if so, we close the connection after the request is completed.
Closes #464