Skip to content

Add Python 3.13 support using legacy-cgi#467

Merged
digitalresistor merged 2 commits into
Pylons:mainfrom
luhn:legacy-cgi
Oct 24, 2024
Merged

Add Python 3.13 support using legacy-cgi#467
digitalresistor merged 2 commits into
Pylons:mainfrom
luhn:legacy-cgi

Conversation

@luhn

@luhn luhn commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

A quick fix for #437 while #466 is in progress.

Comment thread setup.py Outdated

@mmerickel mmerickel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to get this shipped in a bugfix release as 1.8.9 if we can just to unblock python 3.13.

@luhn

luhn commented Oct 10, 2024

Copy link
Copy Markdown
Contributor Author

Should I rebase to 1.8 branch?

@luhn

luhn commented Oct 10, 2024

Copy link
Copy Markdown
Contributor Author

Looks like 1.8 branch didn't get 3.12 merged in, so we'd need to backport that as well. #459

Comment thread .github/workflows/ci-tests.yml Outdated
Comment on lines -42 to -46
# Linux and macOS don't have x86 python
- os: "ubuntu-latest"
architecture: x86
- os: "macos-latest"
architecture: x86

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been fixed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a vestige of #468. I'll rebase the branch.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's all good, there are no errors!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitalresistor

Copy link
Copy Markdown
Member

Line 44 in .github/workflows/ci-tests.yml needs to have the architecture removed:

name: "Python: ${{ matrix.py }}-${{ matrix.architecture }} on ${{ matrix.os }}"

@digitalresistor

digitalresistor commented Oct 24, 2024

Copy link
Copy Markdown
Member

Or... I am sorry, do we want to keep x86 architecture stuff in? In that case a rebase may be better. I guess the only platform that it matters on is Windows.

Feel free to rebase and nuke my commit to add x86 support back in.

@luhn

luhn commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

x86 support is already nuked by way of #468, so it shouldn't be in this PR. I'm going to rebase to keep things tidy.

@luhn

luhn commented Oct 24, 2024

Copy link
Copy Markdown
Contributor Author

Done.

@digitalresistor
digitalresistor merged commit e57a91c into Pylons:main Oct 24, 2024
@digitalresistor

Copy link
Copy Markdown
Member

Thanks @luhn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants