Nonant bounds buffer #500
Open
Nonant bounds buffer #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bknueven
force-pushed
the
nonant_bounds_buffer
branch
from
c168b7a to
0e680a9
Compare
This reverts commit 0e680a9.
bknueven
force-pushed
the
nonant_bounds_buffer
branch
from
4e970cd to
912195c
Compare
This reverts commit 10496da.
bknueven
commented
Apr 25, 2025
| if self._outer_bound_update(new_bound, current_bound): | ||
| if cls is None: | ||
| self.latest_ob_char = char | ||
| self.last_ob_idx = 0 |
There was a problem hiding this comment.
Needs to be specialized for Spokes (current strata rank)
| if self._inner_bound_update(new_bound, current_bound): | ||
| if cls is None: | ||
| self.latest_ib_char = char | ||
| self.last_ib_idx = 0 |
There was a problem hiding this comment.
Needs to be specialized for Spokes (current strata rank)
bknueven
commented
Apr 28, 2025
| @@ -332,12 +332,10 @@ def add_reduced_costs_fixer(hub_dict, | |||
| hub_dict["opt_kwargs"]["options"]["rc_options"] = { | |||
| "verbose": cfg.rc_verbose, | |||
| "debug": cfg.rc_debug, | |||
| "use_rc_fixer": cfg.rc_fixer, | |||
There was a problem hiding this comment.
Need to re-think vanilla and generic cylinders -- you might want a reduced costs spoke but not the reduced costs fixer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes updated bounds on nonants to all cylinders, if available. WIP; needs #496.