Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux aarch64 wheel build support #2076

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Aug 11, 2021

Fixes #2075

Summary/Motivation:

Add linux aarch64 wheel support

Changes proposed in this PR:

  • In .github/workflows/release_wheel_creation.yml file did the changes to add linux aarch64 wheel support.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt
Copy link
Contributor

mrmundt commented Aug 11, 2021

Thanks, @odidev , for this PR. We aren't opposed to the idea of adding aarch64 support - however, we do not run tests against aarch64. We have no reason to believe it will not work, but it makes us hesitant to release wheels for something against which we do not test.

While we consider this on our end, can you please test the wheel creation workflow on your fork? That is, either change the trigger to something simpler that is possible to test, or merge this change on your fork and then push a tag to your fork to verify that the wheels are created as intended.

@odidev
Copy link
Contributor Author

odidev commented Aug 13, 2021

@mrmundt I have enabled the wheel creation workflow on my fork. Please refer the below link for logs-

Github actions Link - https://github.com/odidev/pyomo/runs/3319580869?check_suite_focus=true

Please let me know if you any questions?

@mrmundt
Copy link
Contributor

mrmundt commented Aug 13, 2021

Thanks, @odidev , for doing that. We had a discussion offline about this, and we're supportive of this provided that we get testing set up first. As a result, we will likely incorporate the testing into this PR, which may take a bit of time. Thanks in advance for your patience!

@mrmundt mrmundt linked an issue Nov 16, 2021 that may be closed by this pull request
@mrmundt mrmundt merged commit 5d7c30c into Pyomo:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for aarch64 Aarch64 wheel is missing on PyPi
2 participants