Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Custom PyROS Domain Validators #3169

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

shermanjasonaf
Copy link
Contributor

Summary/Motivation:

Following #3159 and this comment in #3126, this PR simplifies a few custom PyROS domain validators which do not require statefulness.

Changes proposed in this PR:

Simplify custom PyROS domain validators.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Member

@jsiirola jsiirola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super-minor change (that was not technically part of this PR, but should be fixed).

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (26e4970) to head (3797608).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   88.38%   88.37%   -0.01%     
==========================================
  Files         846      846              
  Lines       94857    94853       -4     
==========================================
- Hits        83835    83831       -4     
  Misses      11022    11022              
Flag Coverage Δ
linux 86.33% <100.00%> (-0.01%) ⬇️
osx 75.72% <100.00%> (-0.01%) ⬇️
other 86.52% <100.00%> (-0.01%) ⬇️
win 83.81% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsiirola jsiirola merged commit 0b94b39 into Pyomo:main Feb 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants