Skip to content

Skip Tests on Draft and WIP Pull Requests #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Apr 2, 2024

Fixes NA

Summary/Motivation:

We have been getting a lot of Draft and WIP requests lately, and they are cluttering up the CI build queue. We are changing the policy to enforce and tools.

Changes proposed in this PR:

  • Do not run tests on draft PRs and PRs that start with [WIP]
  • Add information to the contributor's guide
  • BONUS: If a test suite is cancelled, don't trigger the code coverage jobs

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@mrmundt mrmundt requested review from jsiirola and blnicho April 2, 2024 19:51
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (f15a1da) to head (00041ff).
Report is 72 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   88.39%   88.39%   -0.01%     
==========================================
  Files         847      847              
  Lines       95272    95272              
==========================================
- Hits        84217    84213       -4     
- Misses      11055    11059       +4     
Flag Coverage Δ
linux 86.33% <ø> (ø)
osx 76.18% <ø> (ø)
other 86.53% <ø> (ø)
win 83.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@blnicho blnicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor rewording suggestion but otherwise this looks good.

Co-authored-by: Bethany Nicholson <[email protected]>
@blnicho blnicho merged commit e69eda7 into Pyomo:main Apr 25, 2024
33 checks passed
@mrmundt mrmundt deleted the skip-draft-prs branch March 19, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants