mosek_direct.py : Fixed iparam parsing and added support for Task.putparam #3488
+19
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter and the parameter value as strings, as long as the "generic" parameter names are used. Fixed: call to putintparam was missing in the isinstance(option, str) conditional when parsing 'iparam'.
|
@Utkarsh-Detha - please run |
|
Thank you for the review, @mrmundt . I ran the formatter as you recommended, with the newest version thereof. |
|
@Utkarsh-Detha could you add a couple tests for these changes? |
|
@Utkarsh-Detha - Pinging again about this! Could you please add in some tests? |
jsiirola
requested changes
Apr 11, 2025
| self._solver_model.putstrparam(param, option) | ||
| elif 'dparam' in key.split('.'): | ||
| self._solver_model.putdouparam(param, option) | ||
| elif 'iparam' in key.split('.'): |
There was a problem hiding this comment.
I worry that there is no else: clause: users who forget to explicitly include .sparam, .dparam, or .iparam will have those options silently ignored.
| elif 'iparam' in key.split('.'): | ||
| if isinstance(option, int): | ||
| self._solver_model.putintparam(param, option) | ||
| elif isinstance(option, str): |
There was a problem hiding this comment.
Same here - without an else, option values that aren't int / str will be silently skipped (this would include, e.g., numpy ints)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
In
_apply_solverputintparamwas missing in theisinstance(option, str)conditional when parsingiparam. Fixed.option.pop('mosek')instead ofoption.pop(0)within the same conditional. Fixed.Summary/Motivation:
A user wanted to be able to pass the value of ALL parameters as strings. MOSEK's optimizer API supports this through the
Task.putparamfunction, which accepts a parameter name (string) and a value (also string).Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: