Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document BlockData.clone #3542

Merged
merged 3 commits into from
Mar 28, 2025
Merged

Document BlockData.clone #3542

merged 3 commits into from
Mar 28, 2025

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

This adds missing documentation for BlockData.clone(), motivated by answering a SO question

Changes proposed in this PR:

  • Document BlockData.clone()

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's missing a comma for grammatical-correctness but this looks great.

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.70%. Comparing base (fc9559f) to head (e9f42b4).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3542   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         888      888           
  Lines      101963   101963           
=======================================
+ Hits        90446    90450    +4     
+ Misses      11517    11513    -4     
Flag Coverage Δ
builders 26.55% <ø> (+<0.01%) ⬆️
default 84.81% <ø> (?)
expensive 33.94% <ø> (?)
linux 86.17% <ø> (-2.29%) ⬇️
linux_other 86.17% <ø> (-0.01%) ⬇️
osx 76.08% <ø> (ø)
win 84.66% <ø> (+<0.01%) ⬆️
win_other 84.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsiirola jsiirola merged commit adb0ab1 into Pyomo:main Mar 28, 2025
35 checks passed
@jsiirola jsiirola deleted the doc-clone branch March 28, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants