Skip to content

Testing and coverage fixes #3549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 1, 2025
+57 −56
Merged

Testing and coverage fixes #3549

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
88f0dd4
Retry gc colelction (fix intermittent pypy failure)
jsiirola Apr 1, 2025
df806df
Update codecov-action version, remove unnecesary step
jsiirola Apr 1, 2025
1d2b57d
Update codecov config
jsiirola Apr 1, 2025
0357523
Add PYOMO_WORKFLOW env var, reduce diffs between workflows
jsiirola Apr 1, 2025
e6f61d8
GHA doesn't support conditions in 'needs:'
jsiirola Apr 1, 2025
053503b
GHA doesn't support empty 'needs:'
jsiirola Apr 1, 2025
3f0ea8b
Switch from env to input for subworkflow flag
jsiirola Apr 1, 2025
4f5a555
Move inputs definition
jsiirola Apr 1, 2025
d4c2899
Debugging
jsiirola Apr 1, 2025
522ea50
Add missing type
jsiirola Apr 1, 2025
418955a
Add missing type
jsiirola Apr 1, 2025
19f98d0
Revert to env.PYOMO_WORKFLOW, hardcode job-level if
jsiirola Apr 1, 2025
734f97d
NFC: fix typo
jsiirola Apr 1, 2025
792e114
Increase test attempts
jsiirola Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
GHA doesn't support conditions in 'needs:'
@jsiirola
jsiirola committed Apr 1, 2025
commit e6f61d8181877ee9dedc6071584da6d15017e85b
4 changes: 2 additions & 2 deletions .github/workflows/test_branches.yml
View file
Original file line number Diff line number Diff line change
@@ -68,7 +68,7 @@ jobs:

build:
name: ${{ matrix.TARGET }}/${{ matrix.python }}${{ matrix.other }}
needs: ${{ endsWith( env.PYOMO_WORKFLOW, 'pr') && 'lint' || '' }}
needs: # Note: GHA does not support conditional dependencies
runs-on: ${{ matrix.os }}
timeout-minutes: 120
strategy:
@@ -768,7 +768,7 @@ jobs:

bare-python-env:
name: linux/3.9/bare-env
needs: ${{ endsWith( env.PYOMO_WORKFLOW, 'pr') && 'lint' || '' }}
needs: # Note: GHA does not support conditional dependencies
runs-on: ubuntu-latest
timeout-minutes: 10
steps:
4 changes: 2 additions & 2 deletions .github/workflows/test_pr_and_main.yml
View file
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ jobs:

build:
name: ${{ matrix.TARGET }}/${{ matrix.python }}${{ matrix.other }}
needs: ${{ endsWith( env.PYOMO_WORKFLOW, 'pr') && 'lint' || '' }}
needs: lint # the linter job is a prerequisite for PRs
runs-on: ${{ matrix.os }}
timeout-minutes: 120
strategy:
@@ -819,7 +819,7 @@ jobs:

bare-python-env:
name: linux/3.9/bare-env
needs: ${{ endsWith( env.PYOMO_WORKFLOW, 'pr') && 'lint' || '' }}
needs: lint # the linter job is a prerequisite for PRs
runs-on: ubuntu-latest
timeout-minutes: 10
steps: