Clean up numeric_expr dispatcher test driver #3551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This is a NFC PR that resolves a bug in the test driver for testing the numeric_expr dispatchers where one test could bleed into the next (specifically, when testing a mutable sum as the first argument, the conversion of that argument to immutable would bleed into the remaining tests in that test group). Fixing this (lines 207 and 263) led to 170 test failures because the baselines were referring to the mutable expressions. Updating the baselines to NOT refer tot he original mutable expressions resulted in identifying 4 tests whose baselines were "materially wrong" (i.e., the test was testing the wrong thing):
Note that this is only affecting test code: the expression system was - and continues to be - doing the right thing.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: