Skip to content

Select the reduction algorithm using SLM when using icpx.#5573

Merged
prckent merged 1 commit intoQMCPACK:developfrom
ye-luo:omptarget-reduction-slm
Jul 14, 2025
Merged

Select the reduction algorithm using SLM when using icpx.#5573
prckent merged 1 commit intoQMCPACK:developfrom
ye-luo:omptarget-reduction-slm

Conversation

@ye-luo
Copy link
Contributor

@ye-luo ye-luo commented Jul 11, 2025

Proposed changes

Promote the current setting from Aurora build script to Intel compiler settings.
I found intel_gpu_bmg (battlemage, lunar lake) requires it to address the failing unit test https://cdash.qmcpack.org/tests/28817264

What type(s) of changes does this code introduce?

  • Build related changes

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

epyc-server

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

Copy link
Contributor

@prckent prckent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ye.

(Safe to merge since the compiler options to use local shared memory are only modified for offload with Intel LLVM.)

@prckent
Copy link
Contributor

prckent commented Jul 14, 2025

Test this please

@prckent prckent enabled auto-merge July 14, 2025 20:36
@prckent prckent merged commit b4e54b2 into QMCPACK:develop Jul 14, 2025
42 checks passed
@ye-luo ye-luo deleted the omptarget-reduction-slm branch August 3, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants