Select the reduction algorithm using SLM when using icpx.#5573
Merged
prckent merged 1 commit intoQMCPACK:developfrom Jul 14, 2025
Merged
Select the reduction algorithm using SLM when using icpx.#5573prckent merged 1 commit intoQMCPACK:developfrom
prckent merged 1 commit intoQMCPACK:developfrom
Conversation
prckent
approved these changes
Jul 14, 2025
Contributor
prckent
left a comment
There was a problem hiding this comment.
Thanks Ye.
(Safe to merge since the compiler options to use local shared memory are only modified for offload with Intel LLVM.)
Contributor
|
Test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Promote the current setting from Aurora build script to Intel compiler settings.
I found intel_gpu_bmg (battlemage, lunar lake) requires it to address the failing unit test https://cdash.qmcpack.org/tests/28817264
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
epyc-server
Checklist