Nexus: New documentation theme and structure#5978
Conversation
|
This is the artifact from the build: https://nexus-workflows--5978.org.readthedocs.build/en/5978/ |
prckent
left a comment
There was a problem hiding this comment.
Block until after next release.
Also, as previously communicated, and while the enthusiasm is acknowledged, we will work with a professional designer on any new logo.
|
Dear all, Brock wanted me to share our communication over Teams as feedback on the manual. I hope it is useful:
|
|
To respond to some of your comments @kayahans:
This is actually two separate comments. First is the documentation of functions like The other comment about inheritance is a good one. To get hyperlinks properly working I have to go in and declare all of the correct crossref aliases through
This is indeed an artifact of there being a variable number of submodules that contribute to one goal. I figured putting all of the There is an additional challenge w.r.t. sections that are labeled 2.2.x in QMCPACK Input, since currently the docstring for
Agreed. I believe all of the text in there is really just for User Guide stuff, but it also is like the
Two notes. One, it accidentally does say 9 modules instead of 5 because I forgot to change it when I copy+pasted that section over from the QMCPACK part. Oops. Second, I could definitely rework those sections to behave more as user-facing documentation than API documentation, and then make the modules themselves clickable so that you can get the in-depth API docs only if the reader is really interested.
Good point. I'll add |
|
Lots of work got done in these commits. I've changed a few things around, made sure to address comments 1(ish), 2, 4, and 7 from @kayahans. Still more work and discussion needed to finalize the rest. |
…acking', remove duplicate members from `periodic_table` documentation
|
Please can you fix the build? Unfortunately there is now some CifFile contamination. This should be removed since we can not require these kinds of optional Nexus dependencies to build the documentation. The documentation should be buildable without optional dependencies. I suggest verifying that the documentation builds in a minimal python environment. |
There's something wrong somewhere else. Even if I have |
|
Looks like a strange bug caused the autodoc Sphinx extension to not be able to import |
Proposed changes
This PR requires #5961 and #5977.
Closes #2716.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Desktop, Fedora Linux 43 (KDE Plasma Desktop Edition)
AMD Ryzen 9 7900X (12 cores, 24 logical processors)
Checklist