Skip to content

Fix #4287 : Improve input exception handling / fix Mac bus error#6031

Open
prckent wants to merge 5 commits into
QMCPACK:developfrom
prckent:fixinput
Open

Fix #4287 : Improve input exception handling / fix Mac bus error#6031
prckent wants to merge 5 commits into
QMCPACK:developfrom
prckent:fixinput

Conversation

@prckent

@prckent prckent commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

Closes #4287

Edited version:

Fix the bug that causes the bus error in MacOS in deterministic-unit_test_estimators .

Following review, the simplified fix is to put a catch all instead of the existing specific catch.

What type(s) of changes does this code introduce?

  • Bugfix

Does this introduce a breaking change?

  • No

What systems has this change been tested on?

mac, gcc 15 macports.

Checklist

    • I have read the pull request guidance and develop docs
    • This PR is up to date with the current state of 'develop'
    • Code added or changed in the PR has been clang-formatted
    • This PR adds tests to cover any new code, or to catch a bug that is being fixed
    • Documentation has been added (if appropriate)

@ye-luo ye-luo requested a review from PDoakORNL July 8, 2026 16:19
@prckent prckent changed the title Fix #4287 : Improve input exception handling Fix #4287 : Improve input exception handling / fix Mac bus error Jul 8, 2026
@prckent

prckent commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@PDoakORNL I removed the macos bypass for the previously failing test =>Provided the macos CI passes you have confirmation that this works without needing to reproduce it locally.

@PDoakORNL PDoakORNL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to go see if I can still reproduce the Mac but, but I have questions about why MultiReal was missing from the unit test or removed when it seems like it would have caught a real bug. Also is this feature just not used in any other testing or if it was how could it have worked on any system.

Comment thread src/Estimators/InputSection.cpp Outdated
Comment thread src/Estimators/InputSection.cpp

@PDoakORNL PDoakORNL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix and return of the unit testing of multireal is good, the refactor and possible copy optimization is uncessary please remove.

Comment thread src/Estimators/InputSection.cpp Outdated
Comment thread src/Estimators/InputSection.cpp Outdated
@prckent

prckent commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Simplified by hand. Just kept the assignValue multiReal fix (was a vector of strings and not reals). I also expanded the outer catch to be a conservative catch all in case there are any other problems lurking here. Next time we will at least get an error from the correct area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Estimator unit test fails on M1 Mac with gcc

2 participants