Fix #4287 : Improve input exception handling / fix Mac bus error#6031
Fix #4287 : Improve input exception handling / fix Mac bus error#6031prckent wants to merge 5 commits into
Conversation
|
@PDoakORNL I removed the macos bypass for the previously failing test =>Provided the macos CI passes you have confirmation that this works without needing to reproduce it locally. |
PDoakORNL
left a comment
There was a problem hiding this comment.
I need to go see if I can still reproduce the Mac but, but I have questions about why MultiReal was missing from the unit test or removed when it seems like it would have caught a real bug. Also is this feature just not used in any other testing or if it was how could it have worked on any system.
PDoakORNL
left a comment
There was a problem hiding this comment.
The fix and return of the unit testing of multireal is good, the refactor and possible copy optimization is uncessary please remove.
|
Simplified by hand. Just kept the assignValue multiReal fix (was a vector of strings and not reals). I also expanded the outer catch to be a conservative catch all in case there are any other problems lurking here. Next time we will at least get an error from the correct area. |
Proposed changes
Closes #4287
Edited version:
Fix the bug that causes the bus error in MacOS in deterministic-unit_test_estimators .
Following review, the simplified fix is to put a catch all instead of the existing specific catch.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
mac, gcc 15 macports.
Checklist