Nexus: [Draft] Expanding dynamic workflows - #6146
Draft
kayahans wants to merge 3 commits into
Draft
Conversation
Contributor
|
Thanks Kayahan, this looks great! It will take me some time to dig through this. |
kayahans
marked this pull request as draft
August 26, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR that combines two different aspects of handling dynamic workflows. Unfortunately it combines a few different directions but it is not intended to be pushed to the code. Orthogonal smaller PRs will follow including testing.
Pwscfclass, open for discussion.Two examples provided: 1. 03_chain reproduces Jaron's examples in 02. 2. 04_pwscf_recover reruns 03_example but using electron_maxstep=2 to simulate non-converging QE calculations for each ecut value. Running that job produces the following output in Nexus log in verbose mode:
params vs next_params indicate the changes in the input parameters. It indicates that the existing QE object is recycled while input parameters are modified.
Here is how the scf_50 directory looks like after these attempts:
After ecut_50 job is completed, the script advances to ecut_70 and so on.
What type(s) of changes does this code introduce?
Does this introduce a breaking change?
What systems has this change been tested on?
Checklist