Skip to content

Comments

Feature/table personalization#224

Merged
darinkelkhoff merged 7 commits intodevelopfrom
feature/table-personalization
Sep 11, 2025
Merged

Feature/table personalization#224
darinkelkhoff merged 7 commits intodevelopfrom
feature/table-personalization

Conversation

@darinkelkhoff
Copy link
Contributor

@darinkelkhoff darinkelkhoff commented Sep 11, 2025

Pull Request

📝 Description

What does this PR do?
mostly fix field-name validation added recently in this branch to AggregateAction, to work for non-explicitly-joined tables.

Related Issue:
Closes #[issue_number]

🔍 Type of Change

  • Bug Fix - Fixes an existing issue
  • New Feature - Adds new functionality
  • Breaking Change - Fix or feature that would cause existing functionality to not work as expected
  • Documentation Update - Updates documentation
  • Refactoring - Code change that neither fixes a bug nor adds a feature
  • Performance Improvement - Code change that improves performance
  • Test Addition - Adding missing tests or correcting existing tests

🧪 Testing

How has this been tested?

  • Unit Tests: All unit tests pass
  • Integration Tests: Integration tests pass
  • Coverage: Meets QQQ's coverage requirements (80% instructions, 95% classes)
  • Manual Testing: Tested manually in development environment

Test Commands:

# Commands used for testing
mvn test
mvn verify

📋 Checklist

Before submitting this PR, please ensure:

  • Code Style: Follows QQQ's Code Review Standards
  • Tests: All tests pass with required coverage
  • Documentation: Updated relevant wiki pages and code comments
  • Breaking Changes: Documented any breaking changes
  • Commit Messages: Follow conventional commit format
  • Self Review: Code has been reviewed by the author

🔗 Related Resources

Documentation:

📊 Additional Information

Any additional information that reviewers should know:

  • Screenshots (if applicable)
  • Performance impact
  • Migration notes
  • Dependencies added/removed

Thank you for contributing to QQQ! 🚀

… tables

This involved constructing a JoinsContext inside the validation method - which (as it originally should have been) was moved out of QueryAction, into new SelectionValidationHelper.
…hat queryJoin objects are marked as for being selected; avoid NPE on null join table.
… for finishClone, to help with backward compat ability
…ly inserted associated records

This change was added in previous commits in this branch on InsertAction, so this gets some test coverage in on it as well.
…Context in SelectionValidationHelper too, so it should not be able to impact anything (since apparently it has side effects all over the place).
@darinkelkhoff darinkelkhoff merged commit d60caa1 into develop Sep 11, 2025
15 of 21 checks passed
@github-actions
Copy link

🔒 Security Scan Complete

Dependency vulnerability scan completed for this PR. View full report

@darinkelkhoff darinkelkhoff deleted the feature/table-personalization branch September 29, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant