Merged
Conversation
… tables This involved constructing a JoinsContext inside the validation method - which (as it originally should have been) was moved out of QueryAction, into new SelectionValidationHelper.
…ecognized table name
…hat queryJoin objects are marked as for being selected; avoid NPE on null join table.
… for finishClone, to help with backward compat ability
…ly inserted associated records This change was added in previous commits in this branch on InsertAction, so this gets some test coverage in on it as well.
…Context in SelectionValidationHelper too, so it should not be able to impact anything (since apparently it has side effects all over the place).
|
🔒 Security Scan Complete Dependency vulnerability scan completed for this PR. View full report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📝 Description
What does this PR do?
mostly fix field-name validation added recently in this branch to AggregateAction, to work for non-explicitly-joined tables.
Related Issue:
Closes #[issue_number]
🔍 Type of Change
🧪 Testing
How has this been tested?
Test Commands:
📋 Checklist
Before submitting this PR, please ensure:
🔗 Related Resources
Documentation:
📊 Additional Information
Any additional information that reviewers should know:
Thank you for contributing to QQQ! 🚀