Add time dependence to analytic doppler#32
Merged
Conversation
Contributor
|
The unit test failures appear to be due to changes in ARC 3.9.0. Without testing, I suspect they are do to increased precision in a constant used in the wavefunction calculations nikolasibalic/ARC-Alkali-Rydberg-Calculator#192. We should probably go ahead and relax the tolerance on these two checks (and update the hard-coded one with the new value). I'll go ahead and knock together a separate PR. |
Modify analytic doppler solver to handle time dependence of parameters by solving for steady state at the t=0 values.
camontag
force-pushed
the
add_time_analytic
branch
from
d8915aa to
31719b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify analytic doppler solver to handle time dependence of parameters by solving for steady state at the t=0 values.