Lazy imports#36
Merged
Merged
Conversation
Prevents one reason for matplotlib from being imported at rq import
This, with other tweaks, removes arc and matplotlib from rq import unless asked for by the user (ie `draw_diagram` or `Cell` used). Works, but is a bit ugly. Reduces `rq` import from 2.8s to 1.5s.
…tion instead of a dict of imported classes.
Contributor
Author
|
For posterity sake, here are the import timings before and after lazy implementation. Note that these are with numpy 2. Numpy 1 imports are a fair bit slower overall. Before: After: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements lazy imports for
leveldiagramandarc, which improves import time of rydiqule by about a second (2.8s to 1.8s). Note thatleveldiagramwill be imported at the first call ofdraw_diagramandarcis imported at the first instantiation of aCell, so the extra import times will show up at that point.While mostly alleviating a personal pet-peeve, these changes lay the ground work for allowing ARC to be an optional dependency, since it is only required for
Celland particularly for modeling Rydberg atoms. Nominally rydiqule has a wider purview, so making ARC officially optional at some future point may be desireable.