Addressing JOSS reviewer 1 comments#41
Merged
Merged
Conversation
dihm
force-pushed
the
rev1_comments
branch
2 times, most recently
from
bd75b21 to
8d9ad83
Compare
- Latex fix - Add section describing how to undo computational basis transformation on solutions.
- Fix bad latex rendering on web - Fix borked plot - Clarify rydiqule computation speed benefits and limitations
expanding on contribution guide in README.
…iqule performance.
… conversion to the complex basis.
Contributor
Author
|
Comments approved by reviewer. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses comments from JOSS reviewer @a-eghrari, which can be found here.
Please see the linked issue for response, with this PR acting as a place for more in-depth conversation (as needed).