Hotfix release v2.1.3#65
Merged
Merged
Conversation
Fixes #64 where `Solution.coupling_rabi` would fail if any coupling in a group was not dipole allowed. It fixes the labeling in `Sensor.dm_basis` to correctly match that of the calculation basis. It also adds the `kmag_detuning_correction` kwarg to `Cell.add_single_coupling` so that couplings with large detunings can correctly calculate the k-vector magnitude.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64 where
Solution.coupling_rabiwould fail if any coupling in a group was not dipole allowed.It fixes the labeling in
Sensor.dm_basisto correctly match that of the calculation basis.It also adds the
kmag_detuning_correctionkwarg toCell.add_single_couplingso that couplings with large detunings can correctly calculate the k-vector magnitude.