push all 3 files (readme, code and notes) under single commit#245
push all 3 files (readme, code and notes) under single commit#245BRO3886 wants to merge 3 commits into
Conversation
uses ref, blob and tree apis from github to create a single commit per submission. Also removes the need for update and upload actions and methods since github can calculate diffs between blobs This will reduce the amount of commits so that your git history remains cleaner. Also, does not upload notes if notes length is 1
|
@QasimWani :) |
|
Please. 3 commits for every submission is a bit much :) |
|
Yes! To recruiters who takes a look at our profile, it looks like we just did leetcode for the sake of increasing our commits! |
|
The feature looks great! |
|
@QasimWani need this very much |
|
I want that function, too. The number of unnecessary commits seems to exaggerate my history. |
li935
left a comment
li935
left a comment
There was a problem hiding this comment.
This is a necessary development for us.
| } | ||
| } | ||
|
|
||
| const getCodeAndMsg = async (msg) => { |
There was a problem hiding this comment.
you're creating a lot of tech debt with these two new functions. also, it doesn't incorporate updating local windows storage when you've already solved the problem before. Solving same problem keep increasing up your problem count tally.
| const token = res.leethub_token; | ||
| const mode = res.mode_type; | ||
| const hook = res.leethub_hook; | ||
| const stats = res.stats; |
There was a problem hiding this comment.
this should be a var. You're changing the value of stats later in the function.
QasimWani
left a comment
QasimWani
left a comment
There was a problem hiding this comment.
incorporate new functions into existing scripts.
|
would not be able to pick it right now due to some personal commitments, @QasimWani, please feel free to close. You can also assign it to someone who wants to work on this further |
|
Please remove 3 commits for every solution. |
9 participants
No description provided.