fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A#279
Open
IcePigZDB wants to merge 1 commit intoQihoo360:masterfrom
Open
fix: update error parameter from 3 to 2 in tableNameCollector in case of A.A.A#279IcePigZDB wants to merge 1 commit intoQihoo360:masterfrom
A.A.A#279IcePigZDB wants to merge 1 commit intoQihoo360:masterfrom
Conversation
IcePigZDB
changed the title
A.A.A, should be 2
IcePigZDB
changed the title
A.A.A
IcePigZDB
changed the title
A.A.AA.A.A
IcePigZDB
force-pushed
the
update-tableNameCollector
branch
from
a99880b to
0413e9c
Compare
IcePigZDB
force-pushed
the
update-tableNameCollector
branch
from
0413e9c to
be16932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Please describe in detail here)Checklist
Description
Current error parameter in
validateTableNamecan not throw exception in case ofA.A.A, seetestParseSingleBdNameAndTableNameWithErrorandtestParseSingleBdNameAndTableNameWithError2. So I change it to2from3.Does this PR introduce a breaking change?