Allow connection to remote SuperCollider#243
Open
alejandrosame wants to merge 4 commits intoQirky:masterfrom
Open
Allow connection to remote SuperCollider#243alejandrosame wants to merge 4 commits intoQirky:masterfrom
alejandrosame wants to merge 4 commits intoQirky:masterfrom
Conversation
Qirky
requested changes
Jun 23, 2021
Owner
Qirky
left a comment
Qirky
left a comment
There was a problem hiding this comment.
Sorry for the delay - haven't been very good at keeping an eye on PRs but this mostly looks good. Will need to test it out though but other than a small change I'll hope to add this in the next update
FoxDot/lib/Settings/__init__.py
Outdated
Comment on lines
126
to
127
| if os.path.isfile(FOXDOT_INFO_FILE): | ||
| os.remove(FOXDOT_INFO_FILE) |
Owner
There was a problem hiding this comment.
Might be better to move this into the try/except before you write the file? Just in case - for whatever reason - the template file doesn't exist and then there is no info file on start up
Author
There was a problem hiding this comment.
Indeed that makes sense, already pushed the update. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue addresses points 1-3 in #242.
The least intrusive solution I thought about was retrieving the proper path prefixes when retrieving the server info. This has the drawback of leaking information about the server setup that shouldn't be known by the client, which is problematic if this approach is to be used in an eventual "serious" service or in a public network. However, for personal and controlled used it's enough and doesn't require any heavy code or project refactoring.