Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2025

Add Qiskit Installer for Windows to list.


Closes #877

@github-actions github-actions bot added the submission Project submission label May 6, 2025
@CLAassistant
Copy link

CLAassistant commented May 6, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sorry for the delay in reviewing

@@ -0,0 +1,12 @@
name = "Qiskit Installer for Windows"
url = "https://github.com/ket-q/qiskit_windows_installer"
description = "QIWI, the Qiskit Installer for WIndows, will set up Qiskit and a local copy of Visual Studio Code (VS Code) on your computer, with a ready-to-use Python virtual environment for Jupyter notebooks or Python files."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description needs to be <135 characters, is this ok?

Suggested change
description = "QIWI, the Qiskit Installer for WIndows, will set up Qiskit and a local copy of Visual Studio Code (VS Code) on your computer, with a ready-to-use Python virtual environment for Jupyter notebooks or Python files."
description = "Set up Qiskit and Visual Studio Code (VS Code), with a ready-to-use virtual environment for Jupyter notebooks or Python files."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm going to merge this to move things forward, but please make an issue if you want it changing.

@frankharkins
Copy link
Member

Ah, @AxelPetitt can you please sign the CLA?

@AxelPetitt
Copy link
Contributor

Hello @frankharkins,
Our university just approved the signing of the CLA.
The repository I submitted is the public one but we are actually two contributors on that project. We each contributed ~1k LOC to the project. Should he also sign the CLA ?

@frankharkins frankharkins enabled auto-merge (squash) July 8, 2025 09:49
@frankharkins frankharkins merged commit affd341 into main Jul 8, 2025
4 checks passed
@frankharkins
Copy link
Member

No, just you signing is fine thanks – the CLA is just for the contribution to this repo (~10 LOC), it doesn't affect your project's code.

@frankharkins frankharkins deleted the submission-877 branch July 8, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

submission Project submission

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Submission]: Qiskit Installer for Windows

3 participants