-
Notifications
You must be signed in to change notification settings - Fork 195
Include ruff as part of the tooling #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yaelbh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do qiskit and samplomatic also employ both pylint and ruff?
Qiskit employs both (ruff in an experimental capability) and samplomatic just ruff. |
yaelbh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also use only ruff, there's no reason to spend time with two linters. Not in this PR of course.
I like that thought actually - |
Summary
Introduce
ruffas an additional linter, in order to cover some more checks (and automated fixes) with minimal performance hit:--fixoption, except for hand-introducednoqaentriesmake linttargetDetails and comments
Fixes #2513