[executor_preview] Document broadcasting conventions #2566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelbh
reviewed
Jan 15, 2026
| * - ``(4, 3)`` | ||
| - ``(2, 4, 3)`` | ||
| - 4×3=12 configs, 2 randomizations each | ||
|
|
Collaborator
There was a problem hiding this comment.
It's an excellent document, clear and clean.
How about input extrinsic=(4, 3) and shape=(2, 1, 3)? Is (2, 1, 3) broadcastable from (4, 3)? Our code allows this example, and the result has 12 configs, 2 randomizations each. If it's valid then it deserves an example and a dedicated explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a guide to describe broadcasting semantics of the Executor and QuantumProgram in detail. IT also updates some docstrings to be consistent with the guide.
Details and comments
Fixes #