Re-organize into submodules.#15
Conversation
The following commits organize the `qiskit-rs` crate into different submodules. We understand that with the expansion of the C API we will have further additions into the API and we need to think about how we organize the many features as they will be included. Since we currently only have circuit feaures, the only module exposed will be the `circuit`.
Mimicking what was done in the main qiskit repository, this commit separates the `Observable`, `BitTerm` and `BitTermList` into its own crate called `quantum_info`.
emilkovacev
left a comment
emilkovacev
left a comment
There was a problem hiding this comment.
Thanks for the PR! I put a few comments/suggestions, but I think this is almost ready to merge.
| // copyright notice, and modified files need to carry a notice indicating | ||
| // that they have been altered from the originals. | ||
|
|
||
| use qiskit_rs::{ClassicalRegister, QuantumCircuit, QuantumRegister}; |
There was a problem hiding this comment.
Is there any way to move the files while keeping the imports? In python, QuantumCircuit, ClassicalRegister, and QuantumRegister are importable from Qiskit alone, so this would be consistent with the main interface.
|
|
||
| use super::{Complex64, Observable}; | ||
| #[test] | ||
| fn test_new_observable() { |
There was a problem hiding this comment.
With this organization, it could be a great opportunity to standardize where tests are written! My understanding is that the tests directory should be reserved for more holistic tests rather than module tests, is that a pattern that makes sense to uphold?
| // copyright notice, and modified files need to carry a notice indicating | ||
| // that they have been altered from the originals. | ||
|
|
||
| mod observable; |
There was a problem hiding this comment.
Can you add module-level docs for the observable module? Something about what belongs in this module would be great.
| // copyright notice, and modified files need to carry a notice indicating | ||
| // that they have been altered from the originals. | ||
|
|
||
| mod quantum_circuit; |
There was a problem hiding this comment.
Can you add module docs for this module?
2 participants
Fixes #11
The following commits organize the
qiskit-rscrate into different submodules. We understand that with the expansion of the C API we will have further additions into the API and we need to think about how we organize the many features as they will be included. Since we currently only have circuit feaures, the only module exposed will be thecircuit.