Gate callers check qubits#25
Merged
Merged
Conversation
|
|
emilkovacev
requested changes
Feb 2, 2026
emilkovacev
left a comment
emilkovacev
left a comment
Member
There was a problem hiding this comment.
Thanks for looking into this! I added a few nits, but overall the tests and code changes seem reasonable.
review updates circuit ins test error
Contributor
Author
|
@emilkovacev Thanks for the review, I've been through and updated. The only other change is to |
emilkovacev
approved these changes
Feb 8, 2026
|
|
||
| /// Check if all qubits are within the range of the circuit. | ||
| /// | ||
| /// Mutable as `num_qubits()` takes a mutable reference. |
Member
There was a problem hiding this comment.
It might be worth revisiting this, since I see that fn num_instructions uses an immutable self. That being said it's likely out of scope of this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #24, it is currently possible to pass invalid qubit indices to
QuantumCircuit::gate().This PR:
gateas unsafe, adding safety docstring.QiskitError:MismatchedQubitswhen the quantum register is too small or invalid qubit indices are used.Any feedback or comments are very welcome! I'm sure there's a cleaner way to implement the tests but keeping them simple and explicit seemed fine for now.