Skip to content

Conversation

paaragon
Copy link
Collaborator

@paaragon paaragon commented Oct 6, 2025

Summary

This PR fixes the /swagger endpoint that was broken because of serialises name collision.

Details and comments

In the future, every time we write an input serializer, we should add:

 class Meta:
        """Meta class to define input serializer name"""

        ref_name = "{Your Endpoint}InputSerializer"

@paaragon paaragon requested a review from a team as a code owner October 6, 2025 10:52
@korgan00
Copy link
Collaborator

korgan00 commented Oct 8, 2025

Maybe we can do it only when we have collisions instead of spread all the code with this.

@Tansito
Copy link
Member

Tansito commented Oct 9, 2025

I see your point @korgan00 , we can discuss it, in this case as it doesn't add to much noise to the class I think I prefer to have it so we can "standardize" it a bit and avoid problems. If we would need to have more "boilerplate" yeah, but it's only add a parameter (and temporary meanwhile we have serializers).

Copy link
Member

@Tansito Tansito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It worked like a charm, @paaragon , thanks! I will wait to merge until we can discuss what @korgan00 commented in his previous message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants