Oxidize CircuitData blocks (to also be CircuitDatas).
#15123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change also moves ownership of basic blocks in Rust (the nested
circuits within control flow operations) to the containing circuit, i.e.
either CircuitData or DAGCircuit. As such, basic blocks now have the same
type as their container (no need to convert from CircuitData to a DAGCircuit
when you're accessing a control flow operation in a DAG context.
In Python, there is no change since we rebuild control flow operations
to avoid an API break.
Control flow instructions can be accessed by calling a
`try_view_control_flow` method of the circuit type, which provides the
following ergonomic view:
pub enum ControlFlowView<'a, T> {
Box(Option<&'a Duration>, &'a T),
BreakLoop,
ContinueLoop,
ForLoop {
indexset: &'a [usize],
loop_param: Option<&'a PyObject>,
body: &'a T,
},
IfElse {
condition: &'a Condition,
true_body: &'a T,
false_body: Option<&'a T>,
},
Switch {
target: &'a Target,
cases_specifier: Vec<(&'a Vec<CaseSpecifier>, &'a T)>,
},
While {
condition: &'a Condition,
body: &'a T,
},
}
|
One or more of the following people are relevant to this code:
|
jakelishman
added
on hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Built on top of #14568. This is just the mechanical change of moving
CircuitData's block type to also beCircuitDatainstead ofPy<PyAny>.For a readable diff until that merges, see here:
kevinhartman/qiskit@oxidize-ctrl-flow...kevinhartman:qiskit:oxidize-circ-blocks
Details and comments
Todo: