Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 9, 2025

Changes:

  • Updated the instruction deep-copy logic so copying a circuit now recursively clones its parameters, ensuring BoxOp bodies are duplicated instead of shared between the original and the copy.
  • Added a test to verify that copying a circuit containing a BoxOp produces an independent body that can be mutated without affecting the original circuit.

Why?


This is an automatic backport of pull request #14918 done by [Mergify](https://mergify.com).

* Deep copy BoxOp bodies when copying circuits

* Deep copy BoxOp bodies when copying circuits

* Deep copy BoxOp bodies when copying circuits

* added releasenote

* Simplify deepcopy and address comments

(cherry picked from commit f2c4bb2)
@mergify mergify bot requested a review from a team as a code owner October 9, 2025 23:04
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@github-actions github-actions bot added Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Oct 9, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18391418026

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 26 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.01%) to 88.391%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.63%
crates/qasm2/src/lex.rs 4 92.27%
crates/circuit/src/parameter/symbol_expr.rs 9 72.9%
crates/qasm2/src/parse.rs 12 97.09%
Totals Coverage Status
Change from base Build 18354852432: -0.01%
Covered Lines: 92300
Relevant Lines: 104422

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Bugfix Include in the "Fixed" section of the changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants