Add use_seeking kwarg to qpy.dump for manual override of seek behaviour
#15161
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiskit-bot
added
the
Community PR
|
Fixes #15157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds on top of #15158 and introduces an optional
use_seekingkeyword argument to qpy.dump. Fixes #15157Details and comments
This provides explicit user control over whether QPY uses the in-place seek table or the buffered write path.
use_seeking=None-> automatic detection (based onseekable()andKNOWN_BAD_SEEKERS).use_seeking=True-> force the in-place seek path.use_seeking=False-> force the buffered path.This gives users full control in environments with custom stream wrappers.
This PR should target Qiskit 2.3, while #15158 remains the bug-fix-only change backported to 2.2.2.