Add impls of ProgramNode for various math operations#16107
Open
ihincks wants to merge 3 commits into
Open
Conversation
ihincks
added
Rust
Collaborator
|
One or more of the following people are relevant to this code:
|
Open
Coverage Report for CI Build 26910781949Coverage decreased (-0.08%) to 87.387%Details
Uncovered Changes
Coverage Regressions12 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
ihincks
force-pushed
the
program-node-math
branch
2 times, most recently
from
b429b8d to
a437668
Compare
ihincks
changed the title
ihincks
force-pushed
the
program-node-math
branch
4 times, most recently
from
31adc4f to
768edb2
Compare
Collaborator
|
One or more of the following people are relevant to this code:
|
ihincks
commented
May 16, 2026
| let Tensor::Bit(y_arr) = y else { | ||
| unreachable!() | ||
| }; | ||
| // TODO: I think this call will panic on bad broadcast? we need an error |
Contributor
Author
There was a problem hiding this comment.
Flagging TODO with comment. There's more than one like this.
ihincks
commented
May 16, 2026
Comment on lines
+75
to
+78
| let x = require_typed_leaf_arg(args, "x", DType::Bit)?; | ||
| let Tensor::Bit(x_arr) = x else { | ||
| unreachable!() | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
I'm not entirely happy with this pattern that involves the unreachable statement...but I'm also not sure exactly how to best refactor.
ihincks
force-pushed
the
program-node-math
branch
3 times, most recently
from
a590a50 to
2be78bc
Compare
3 tasks
ihincks
force-pushed
the
program-node-math
branch
2 times, most recently
from
73504ec to
d590df2
Compare
ihincks
force-pushed
the
program-node-math
branch
from
d590df2 to
2faeeae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #16031 by implementing ProgramNode for various math-y structs.
PR Stack
AI/LLM disclosure