Add release note for nalgebra 2q synthesis changes#16129
Conversation
In the recently merged Qiskit#16065 we added a new release note section to highlight performance changes that weren't additions. Since that has merged for the 2.5 release the PR series migrating our internal 2q synthesis code to use nalgebra should be documented under this section for the 2.5.0 release notes. Since those PRs (Qiskit#15960 and Qiskit#15928) merged before Qiskit#16065 did there was no release note documenting this change. This commit corrects that oversight and adds the release note so we're documenting this improvement in the performance section.
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 26493870714Coverage decreased (-0.003%) to 87.602%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions19 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
I didn't since it wasn't really about performance on it's own. It was in service of the note I added here. On it's own changing the internal return type doesn't do much because it would just use an ndarray for the synthesis. But when combined with the later PRs we get the performance improvement by doing all the matrix storage with nalgebra
I think it probably should be a performance release note. But it's kind of independent from this release note PR (which is adding the missing one for the nalgebra migration). I think that it's something we can do in the release note roundup when we prepare the final 2.5.0 release. |
ShellyGarion
left a comment
There was a problem hiding this comment.
One minor fix and it's ready to go :)
I think it probably should be a performance release note. But it's kind of independent from this release note PR (which is adding the missing one for the nalgebra migration). I think that it's something we can do in the release note roundup when we prepare the final 2.5.0 release.
I'll try to remind the release manager of Qiskit 2.5 about this when preparing the release PR :)
…d.yaml Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com>
done as part of #16454 |
In the recently merged #16065 we added a new release note section to highlight performance changes that weren't additions. Since that has merged for the 2.5 release the PR series migrating our internal 2q synthesis code to use nalgebra should be documented under this section for the 2.5.0 release notes. Since those PRs (#15960 and #15928) merged before #16065 did there was no release note documenting this change. This commit corrects that oversight and adds the release note so we're documenting this improvement in the performance section.
AI/LLM disclosure