Feature: measure arrows option in draw_circuit rust function#16414
Feature: measure arrows option in draw_circuit rust function#16414OnyxBrumeSky wants to merge 7 commits into
Conversation
…o help me understand how to implement the feature.
OnyxBrumeSky
changed the title
|
Hello @eliarbel, I just finished the feature I was assigned to. Please tell me if any changes need to be done. And sorry for this late pr, I was quite busy until now. Thank you and have a great day |
qiskit-bot
added
the
Community PR
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
|
@OnyxBrumeSky - thanks for opening a PR and aim to solve the issue. |
There was a problem hiding this comment.
Thanks, @OnyxBrumeSky , for working on this! This is a nice start but there is still some work to be done before it's ready to merge. Please see my inline comments.
In addition:
- Please add a release note to describe the change in the C API. It should contain an
features_centry for the config struct, and I think alsofeatures_visualizationfor the functional change in the drawer. - Please update the PR title to something more descriptive since it will be used in the release changelog.
- Please correct the AI/LLM usage checkboxes in the PR description to accurately reflect your LLM usage.
| inst.op.view(), | ||
| OperationRef::StandardInstruction(StandardInstruction::Measure) | ||
| ) { | ||
| Self::get_label(inst).to_string() // Skip space padding around the label to make Measure box thinner |
There was a problem hiding this comment.
Currently your PR does not add the clbit information to the label of the Measure box, when measure_arrows=false. This might be a good place to handle that.
There was a problem hiding this comment.
Hello, I started working on the other suggestions, but I am a bit unsure about this one.
Is there already an implementation of this behavior in the Python drawer that I could refer to?
Otherwise, do you have any suggestion on how the measurement should be drawn in this case?
Would something like this be the expected behavior?
┌───┐┌─────┐
q1: ┤ H ├┤M->c1├
└───┘└─────┘
c1: ════════════
…nts drawing when measure_arrows=false. Need to rewrite tests to fit already existing format
4 participants
AI/LLM disclosure
Feature: Added the option
measure_arrowsto thedraw_circuitfonction in the rust crate as mentionned in #15849 . Now, lines to show measurements can be displayed or not.