Bump nalgebra version to 0.35#16437
Open
mtreinish wants to merge 1 commit into
Open
Conversation
With Qiskit#16435 increasing our rust-numpy version to the latest release 0.29 this corresponded with a change in the allowed versions of the nalgebra used by that crate. Previously we had been blocked from using nalgebra 0.35 because rust-numpy could not handle that version of the crate and we wouldn't be able to pass nalgebra matrices to Python or vice versa. This commit bumps the version of nalgebra we use to 0.35. The one downside to this change however is that nalgebra increases their MSRV to 1.89 from 1.87 that was used for 0.34. This means to leverage this crate Qiskit has to bump its MSRV too. Since we just did that for nalgebra 0.34 in this release cycle we have a choice to make, either bump Qiskit's MSRV in 2.5 to 1.89 instead 1.87 or defer this package upgrade for a future release. If we decide the latter we can just mark this on hold until we're ready to bump the MSRV again. The rust code changes were autofixes from clippy to new rules that are enabled with the new MSRV.
Collaborator
|
One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #16435 increasing our rust-numpy version to the latest release 0.29 this corresponded with a change in the allowed versions of the nalgebra used by that crate. Previously we had been blocked from using nalgebra 0.35 because rust-numpy could not handle that version of the crate and we wouldn't be able to pass nalgebra matrices to Python or vice versa. This commit bumps the version of nalgebra we use to 0.35.
The one downside to this change however is that nalgebra increases their MSRV to 1.89 from 1.87 that was used for 0.34. This means to leverage this crate Qiskit has to bump its MSRV too. Since we just did that for nalgebra 0.34 in this release cycle we have a choice to make, either bump Qiskit's MSRV in 2.5 to 1.89 instead 1.87 or defer this package upgrade for a future release. If we decide the latter we can just mark this on hold until we're ready to bump the MSRV again.
The rust code changes were autofixes from clippy to new rules that are enabled with the new MSRV.
AI/LLM disclosure