Skip to content

Add control-flow checks to Rust check_map#16445

Open
Sonai124 wants to merge 1 commit into
Qiskit:mainfrom
Sonai124:fix-rust-check-map-control-flow
Open

Add control-flow checks to Rust check_map#16445
Sonai124 wants to merge 1 commit into
Qiskit:mainfrom
Sonai124:fix-rust-check-map-control-flow

Conversation

@Sonai124

@Sonai124 Sonai124 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Fixes #16118

Summary

  • Make the native Rust run_check_map recurse through control-flow blocks.
  • Compose nested control-flow qubit mappings before checking target connectivity.
  • Add Rust unit tests for top-level, control-flow, remapped, and nested control-flow checks.

Tests

  • cargo test -p qiskit-transpiler --lib
  • uv run --group build --group test python -m unittest test.python.transpiler.test_check_map

AI/LLM disclosure

  • I didn't use LLM tooling, or only used it privately.
  • I used the following tool to help write this PR description: ChatGPT, GPT-5.5 Thinking.
  • I used the following tool to generate or modify code: ChatGPT, GPT-5.5 Thinking.

@Sonai124 Sonai124 requested a review from a team as a code owner June 17, 2026 16:20
@Sonai124 Sonai124 requested a review from jakelishman June 17, 2026 16:20
@qiskit-bot qiskit-bot added the Community PR PRs from contributors that are not 'members' of the Qiskit repo label Jun 17, 2026
@qiskit-bot

Copy link
Copy Markdown
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@Sonai124 Sonai124 force-pushed the fix-rust-check-map-control-flow branch from 22592e1 to ef8a80d Compare June 17, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community PR PRs from contributors that are not 'members' of the Qiskit repo

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Add control-flow checks in Rust check_map pass.

2 participants