Add DAG-based variant of BasisTranslator transpiler pass and opaque EquivalenceLibrary type in C Api#16446
Open
bruno-ah-um wants to merge 3 commits into
Open
Add DAG-based variant of BasisTranslator transpiler pass and opaque EquivalenceLibrary type in C Api#16446bruno-ah-um wants to merge 3 commits into
bruno-ah-um wants to merge 3 commits into
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #15783 and #16261
@eliarbel: please review
Summary
Adds
qk_transpiler_pass_basis_translator(), the DAG-based variant of the BasisTranslator standalone transpiler pass in the C API. This function operates directly on aQkDaginstead of aQkCircuit, avoiding circuit↔DAG round-trip conversions when chaining multiple passes together.Introduces
QkEquivalenceLibrary, a new opaque C type that wraps Qiskit's standard gate equivalence library.qk_transpiler_pass_basis_translator()accepts the equivalence library as an explicit input parameter. This PR implements onlyqk_equivalence_library_new_standard()andqk_equivalence_library_free().The key improvement over the standalone variant (qk_transpiler_pass_standalone_basis_translator) is that callers can construct the equivalence library once and reuse it across repeated pass invocations, avoiding the cost of regenerating it on every call.
Tests
4 new C tests in test/c/test_basis_translator.c:
AI/LLM disclosure