[WIP] Split PyDAGCircuit and DAGCircuit#16471
Draft
raynelfss wants to merge 2 commits into
Draft
Conversation
The following commit splits the representations of `DAGCircuit` into: - `DAGCircuit` representing the rust-native implementation of the `DAG` excluding its metadata. - `PyDAGCircuit` the version that gets exposed to Python. `PyDAGCircuit` does not implement `Deref<DAGCircuit>` due to future plans requiring us to implement a reference counted `Circuit` for the Python version of the DAG.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15575
The following commit splits the representations of
DAGCircuitinto:DAGCircuitrepresenting the rust-native implementation of theDAGexcluding its metadata.PyDAGCircuitthe version that gets exposed to Python.PyDAGCircuitdoes not implementDeref<DAGCircuit>due to future plans requiring us to implement a reference countedCircuitfor the Python version of the DAG.This is a work in progress and needs a lot of extra combing and detangling.
AI/LLM disclosure