Preserve StatePreparation width in inverse - #16650
Open
TSS99 wants to merge 1 commit into
Open
Conversation
Contributor
|
Let's give #16431 a chance first, that was opened before and has the exact same fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #16430.
StatePreparation.inverse()rebuilt the inverse gate from the stored integervalue alone, so an explicit
num_qubitsgiven at construction was lost. Forinteger inputs the constructor then re-inferred the minimal width from the
value, e.g.
StatePreparation(1, num_qubits=2).inverse()collapsed to a1-qubit gate.
The fix forwards the original width when rebuilding the inverse, but only for
integer-backed instances —
num_qubitsis invalid for label and vector inputs,so those paths are unchanged.
Tests
Added a regression that appends
StatePreparation(1, num_qubits=2)and itsinverse on the same 2-qubit circuit and checks the result is the identity.
AI/LLM disclosure