-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove redundant name check when adding QuantumCircuit registers.
#16678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−5
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bc648ce
remove redundant name check for add_register on the python side
davidfcohen 294badc
add performance release note
davidfcohen 416d7e1
modify performance release note
davidfcohen 0887a5e
remove create registers test file
davidfcohen f0108cf
modify release notes with performance details
davidfcohen e7b12c1
improve release notes language
davidfcohen b076c0e
touch on redundant error handling in release note
davidfcohen 6e15638
remove test program
davidfcohen 3fa6f55
fix release note typo
davidfcohen 1987348
Merge remote-tracking branch 'upstream/main' into create-register-perf
davidfcohen 3b99b0c
Update releasenotes/notes/create-register-performance-fe392209793d151…
davidfcohen 8aa1893
Apply suggestion from @raynelfss
davidfcohen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| import time | ||
|
|
||
| from qiskit.circuit import ClassicalRegister, QuantumCircuit | ||
|
|
||
| start = time.time() | ||
| size = 10 | ||
| qc = QuantumCircuit(*(ClassicalRegister(5, f"cr_{i:05}") for i in range(size))) | ||
| end = time.time() | ||
| elapsed = (end - start) * 1000 | ||
| print("n=10: ", elapsed) | ||
|
|
||
| start = time.time() | ||
| size = 100 | ||
| qc = QuantumCircuit(*(ClassicalRegister(5, f"cr_{i:05}") for i in range(size))) | ||
| end = time.time() | ||
| elapsed = (end - start) * 100 | ||
| print("n=100: ", elapsed) | ||
|
|
||
| start = time.time() | ||
| size = 1000 | ||
| qc = QuantumCircuit(*(ClassicalRegister(5, f"cr_{i:05}") for i in range(size))) | ||
| end = time.time() | ||
| elapsed = (end - start) * 1000 | ||
| print("n=1000: ", elapsed) | ||
|
|
||
| start = time.time() | ||
| size = 10_000 | ||
| qc = QuantumCircuit(*(ClassicalRegister(5, f"cr_{i:05}") for i in range(size))) | ||
| end = time.time() | ||
| elapsed = (end - start) * 1000 | ||
| print("n=10000: ", elapsed) | ||
|
|
||
| qc = QuantumCircuit(ClassicalRegister(5, "a"), ClassicalRegister(5, "b")) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
releasenotes/notes/create-register-performance-fe392209793d151f.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| performance: | ||
| - | | ||
| Improves runtime performance when creating `QuantumCircuit` with many | ||
| registers. See PR `#16678 <https://github.com/Qiskit/qiskit/pull/16678>` | ||
| for performance details. | ||
|
davidfcohen marked this conversation as resolved.
Outdated
|
||
|
|
||
|
|
||
|
davidfcohen marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.