Removed all slick implementation from core#163
Open
jbarrieSquiz wants to merge 1 commit intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed all references to slick-slider for Core.
Internal reference - QHWT-1169
This pull request removes the dependency on the
slick-carousellibrary from the project. The most important changes include the removal ofslick-carouselfrom various files and the deletion of related CSS and JavaScript code.Dependency removal:
package.json: Removed theslick-carouseldependency.CSS cleanup:
src/components/_global/css/slick/component.scss: Deleted the entire file containingslick-sliderstyles.src/components/_global/css/tags/component.scss: Removedslick-sliderspecific styles.src/components/card_no_action/css/component.scss: Removedqld__slick-controlsstyles.src/styles/global.scss: Removed imports forslick-carouselstyles.JavaScript cleanup:
src/components/_global/js/slick/global.js: Deleted the entire file containingslick-carouselinitialization and settings.src/index.js: Removed theslick-carouselimport.