Skip to content

Fix: Vulnerability issue while uploading images in hotel reviews in front-office. #1643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azhar-Webkul wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Vulnerability issue while uploading images in hotel reviews in front-office. #1643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6b27ba
Vulnerability Issue
Azhar-Webkul Jan 14, 2026
b2a5b52
fixed Vulnerability issue while uploading images in hotel reviews
Azhar-Webkul Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/qlohotelreview/controllers/front/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,16 @@ public function displayAjaxAddReview()
}
}

if (is_array($_FILES) && array_key_exists('images', $_FILES) ) {
$allowedExtensions = array('jpg', 'png');
foreach ($_FILES['images']['name'] as $key => $imageName) {
$extension = Tools::strtolower(pathinfo($imageName, PATHINFO_EXTENSION));
if (!in_array($extension, $allowedExtensions)) {
$errors['general'][] = $imageName . ' ' . $objModule->l('is not a supported image format.','default');
}
}
}

if (!count($errors['by_key']) && !count($errors['general'])) {
$customerReview = QhrHotelReview::getByCustomer(
$objOrder->id_customer,
Expand Down
7 changes: 5 additions & 2 deletions modules/qlohotelreview/views/js/hook/review.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,15 +147,18 @@ var QhrReviewImages = {
reader.readAsDataURL(file);
},
removeFile: function(iInput, iFile) {
var input = $('.images-field input.input-images').get(iInput);
var input = $('.images-field input.input-images').eq(iInput);
var files = $(input).get(0).files;
var dataTransfer = new DataTransfer();
$(files).each(function(iiFile, file) {
if (iiFile != iFile) {
dataTransfer.items.add(file);
}
});
input.files = dataTransfer.files;
input.get(0).files = dataTransfer.files;
if (input.get(0).files.length === 0) {
input.remove();
}
},
resetPreviews: function() {
$('.previews-wrap').html('');
Expand Down