feat(dsh): add configured asset inventory - #102
Conversation
Add qualified filesystem Skill winners and cwd-sensitive Instruction sources under a configured-not-observed evidence boundary. Implements QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. Validated with credential-free native DSH comparison, focused suites, packaging verification, and npm run check. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
There was a problem hiding this comment.
Found two native DSH parity issues that need to be fixed. Both were reproduced against exact head 7ee924beda2c: raw Instruction byte-budget semantics and native DSH home normalization. Existing CI, the current-base merge tree, and the regular test suites are green, but these boundary cases are not covered. After fixing them and adding regression coverage, please also update the spec from Status: Draft to reflect the implemented state.
Align raw Instruction render-budget accounting and DSH home normalization with qualified DSH 0.1.1-rc.2. Addresses maintainer review for Story QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. The change was validated with Node 22.20 and Node 24 focused suites, both pinned native DSH smokes, and the full repository validation sequence with an extended local Vitest timeout for the isolated artifact test. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
Compare explicit-blank DSH home resolution with the spawned process's own cwd so equivalent Windows 8.3 and long-name path spellings do not create a false failure. Addresses the Windows CI portability receipt for Story QoderAI#101 using docs/specs/2026-08-23-101-deepseek-harness-configured-assets.md. Validated with the full DSH configured-assets suite on Node 22.20 and Node 24 plus the pinned native smoke. Co-authored-by: Codex (GPT 5.6 Sol) <codex@openai.com>
phodal
left a comment
There was a problem hiding this comment.
Re-reviewed exact head fc3e983e00e6. Both requested native DSH parity fixes are complete: raw Instruction content now drives render-budget accounting while trimming is limited to deduplication, and DSH home normalization matches the qualified native implementation for blank environment values and both tilde forms. The regression fixtures, pinned native comparison, current-base merge tree, full local validation, and Linux/macOS/Windows CI are green. No remaining findings.
Summary
Adds the first bounded DeepSeek Harness
AGENT_CUSTOMIZEconfigured-assets slice for effective filesystem Skills and cwd-sensitive Instructions. It follows qualified native DSH precedence and ordering, reports configured-not-observed evidence rather than runtime use, and includes credential-free native verification.Why
Traceability and Scope
docs/specs/2026-08-23-101-deepseek-harness-configured-assets.mdASSET_PRACTICES; session-analysis changes; evidence-bundle, report, rendering, or output routing; Quickstart; and claims that configured assets were used at runtime.Change Type
Test and Review Evidence
0.1.1-rc.2discovery/invocation contractnpm run checknpm run pack:verifynpm audit --omit=devManual or visual evidence: This is a non-visual configured-assets and runtime-packaging change. The credential-free native smoke compared filesystem Skill winners, Instruction order and deduplication, byte limits, budgeting, authorization, UTF-8 behavior, and supported symlink cases with pinned DSH owners. Clean-source host and standalone runtime artifacts loaded
agent-customizewithoutERR_MODULE_NOT_FOUND.Risk and Recovery
yaml@2.9.0and closes Antigravity, host-artifact, and standalone runtime-ZIP dependency/license boundaries. No shared agent-customize schema or generated-state host packaging policy changes.AGENT_CUSTOMIZEsupport and its YAML dependency closures; no data migration or cleanup is required.0.1.1-rc.2; later DSH releases require explicit requalification.AI Involvement
Checklist
AGENTS.md,CONTRIBUTING.md, and the relevant canonical-owner guidance.CHANGELOG.md.Not applicable for [Feature]: Add DeepSeek Harness configured-asset inventory for Skills and Instructions #101:
AGENTS.mdpermits CHANGELOG changes only when explicitly required, and the approved Story/spec does not authorize one; canonical adapter and installation documentation are updated instead.