support annotated assign#344
Merged
Merged
Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Contributor
|
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
Roger-luo
added a commit
that referenced
this pull request
Apr 5, 2025
Roger-luo
added a commit
that referenced
this pull request
Nov 6, 2025
This was removed as part of #344, so I'm not sure if it should be added back. However, without this change we always get `IList[AnyType]` unless explicitly specifying the element type in `ilist.New`. This breaks a bunch of tests (and code, really) in bloqade-circuit. Adding this back seemed like the much easier change than explicitly setting the `elem_type` everywhere. --------- Co-authored-by: Roger-luo <rogerluo.rl18@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #324
This PR continues the previous refactor that we change how we dispatch lowering transform for a given
ast.Call, instead we uselowerking.akinto register the lowering pass for a corresponding Python callable. This allows smoother integration with existing packages, e.g fornumpywe can create an IR that mimicsnumpy's API and compile functions calling numpy.In this PR, we support lowering e.g
ilist.IListconstructor intoilist.Newstatement, so that we can write something like the following