You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@copilot The unaryOps general path all do double to float and back conversions.
Why? Is this necessary? If it’s necessary, can we fold it inline into the general ops helper to aid performance?
The explicit .toDouble calls were redundant — Java/Scala widens Float to Double implicitly when calling transcendental functions like Math.exp, Math.log, etc. (since the JVM only provides double-precision versions of those). The .toFloat at the end is still necessary to store the result back into a Float array.
For Math.abs, Java has a float overload (Math.abs(float) → float), so no conversion is needed at all.
Made unaryOpGeneralinline with inline f: Float => Float (matching the existing flatUnaryOp pattern), so the function body gets inlined at each call site instead of going through a virtual dispatch
Removed all redundant .toDouble calls from the general-path lambdas
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.