Only fail tests for enabling the GIL in parallel runs #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
commented
Dec 19, 2025
| "*::test_marker_threads_one PASSED [[]thread-unsafe[]]*", | ||
| "*::test_marker_threads_five PASSED*[[]???%[]]", | ||
| "*::test_marker_threads_two PASSED*[[]???%[]]", | ||
| "*::test_marker_threads_one PASSED*[[]thread-unsafe[]]*", |
Collaborator
Author
There was a problem hiding this comment.
not sure why this doesn't happen on CI, but I needed this for the tests to pass locally.
|
3.15 CI is broken because of python/cpython#142928 |
Collaborator
Author
|
Ping @lysnikolaou - this OK with you? |
lysnikolaou
approved these changes
Dec 23, 2025
Member
lysnikolaou
left a comment
lysnikolaou
left a comment
There was a problem hiding this comment.
LGTM! This reminds me that it probably makes sense to skip everything if configured_num_workers == 1, especially if parallel_threads is removed. But even if it isn't, we can probably figure out a way to count the number of times it's used in the collection pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #158.