add more ruff rules #595
Merged
add more ruff rules #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smokestacklightnin
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked on a couple of projects that used ruff rules extensively, and I enjoyed it for the most part. While I think of some as overzealous, I picked the ones that I found helpful. I like them as maintainer and user because we get (mostly automated) consistency in code style throughout our code without wasting any time during code review on it.
Except for the
ISC,PTH, andASYNCrules, which I remember to commenting manually on PRs in the past, all rules introduced changes. They are 95% automatic. The 5% that I had to fix manually, I just followed the helpruffwas showing. Meaning, only thepyproject.tomlfile has to be reviewed.