Fix: missed OrderStatus in Brokerage OrderTestParameters#8677
Merged
Martin-Molinero merged 1 commit intoQuantConnect:masterfrom Apr 7, 2025
Conversation
Martin-Molinero
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Missed
OrderStatusinOrderTestParameters. When we create a test order in brokerage,OrderStatusis always equal toNone. This is incorrect because when we create a new Lean Order, it must haveOrderStatus = New.Related Issue
N/a
Motivation and Context
Fix bugs and simplify the process of testing in microservices.
Requires Documentation Change
N/a
How Has This Been Tested?
Submitted.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>